Handle bait and switch resources in ACA#9225
Merged
Conversation
- Discovered while fixing issues in docker compose, we don't properly handle bailt and switch resources properly. Since we remove and add a new resource, we end up needing to treat both as the same resource when we encounter it. - Added test for aca and app service (which is missing this feature)
github-actions
bot
added
the
area-integrations
davidfowl
added
area-deployment
and removed
area-integrations
mitchdenny
reviewed
May 10, 2025
| } | ||
|
|
||
| [Fact] | ||
| public async Task AzureAppServiceDoesNotSupportBaitAndSwitchResources() |
Member
There was a problem hiding this comment.
Should you rename this test now that its fixed?
Contributor
Author
There was a problem hiding this comment.
This is app service. When I add support for containers then this will be relevant.
mitchdenny
approved these changes
May 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Checklist